Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support merging configuration from multiple files #25

Merged
merged 4 commits into from
May 25, 2016

Conversation

deric
Copy link
Contributor

@deric deric commented May 18, 2016

I've extended instructions for inheriting configuration from multiple files. It is required to modify inputs and outputs initialization. One way is to modify default params, or move this code to node's definition:

  class { '::telegraf':
    outputs  => hiera_hash('telegraf::outputs'),
    inputs => hiera_hash('telegraf::inputs'),
  }

Official Puppet modules shouldn't contain hiera_hash() calls, but default class parameter initialization doesn't work the same way in Puppet 3. I'll try to add some test for this feature.

@yankcrime
Copy link
Member

Thanks @deric - this also addresses #27.

@yankcrime yankcrime merged commit bf45b4b into voxpupuli:master May 25, 2016
yankcrime pushed a commit that referenced this pull request Jun 1, 2016
Fixes #27. This wasn't implemented correctly in #25. The `$telegraf::params::inputs` and `$telegraf::params::outputs` values are never read because they are only provided as a default value.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants