Now sorting hashes so they don't jumble on every puppet run + properly printing arrays #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build test is failing on something to do with OpenStack API keys, I'm not sure why. I don't think it relates to my commit. |
|
Hi @ntent-ashton - thanks for spotting that issue and offering up a fix. I've tested this with Debian 8.2, CentOS 7 and Ubuntu 14.04 and it looks good to me. If you could fixup your history down to a single commit I'll be happy to merge this in. Don't worry about the failing Travis CI check, it's currently using a personal account to spin up instances on our cloud platform - I'll get around to fixing that later today. |
|
And I've tested it on CentOS 6. |
|
Awesome, thanks! 👍 |
yankcrime
added a commit
that referenced
this pull request
Mar 10, 2016
Now sorting hashes so they don't jumble on every puppet run + properly printing arrays
stuartbfox
referenced
this pull request
in stuartbfox/puppet-telegraf
Mar 31, 2016
Now sorting hashes so they don't jumble on every puppet run + properly printing arrays
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EL6 is still on Ruby 1.8 by default, which doesn't order hashes. It's still a valid backwards compatibility to keep in mind. Without sorting the hashes, every time puppet runs it remakes the file and restarts the process.
Also, for some reason it didn't print out arrays in ['array'] format, but rather as a string. Doing .is_a?(Array) and using value.inspect will force the [''] format.