Normalize Repository file for RHEL and CentOS #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the following we could make use of `yum variables`: https://access.redhat.com/documentation/en-US/Red_Hat_Enterprise_Linux/6/html/Deployment_Guide/sec-Using_Yum_Variables.html Furthermore it might be preferable to set the `descr` field to the value on the official docs instructions: https://www.influxdata.com/package-repository-for-linux/#centos-users
|
You should update the spec as well -- https://github.com/datacentred/puppet-telegraf/blob/f617cd5d0b35179deb73408539824ee997183ec2/spec/classes/telegraf_spec.rb#L81-L93 |
copy pasterino typo :)
|
I'm not sure about the |
Add CentOS specific test
|
Thanks 👍 |
yankcrime
approved these changes
Jan 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the following link we could make use of
yum variables:https://access.redhat.com/documentation/en-US/Red_Hat_Enterprise_Linux/6/html/Deployment_Guide/sec-Using_Yum_Variables.html
Furthermore it might be preferable to set the
descrfield to the value which is used on the official docs instructions:https://www.influxdata.com/package-repository-for-linux/#centos-users
It's rather odd that they use
influxdbas their repository name tho. Which is why I went forinfluxdatainstead.