Pass manage_repo and zabbix_repo to repo.pp and prevent double include #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 21, 2015 13:26
zabbix::repo always used the default when called from zabbix::server. * Add manage_repo to parameters of zabbix::server * Add manage_repo to parameters passed to zabbix::server in init.pp * Add documentation for parameter in server.pp
* Add defined check to all classes which include repo * If it is defined always include it and let the class itself check if it should manage the repo
dj-wasabi
pushed a commit
that referenced
this pull request
Jul 23, 2015
Pass manage_repo and zabbix_repo to repo.pp and prevent double include
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All classes which call zabbix::repo should pass manage_repo and zabbix_version to zabbix::repo.
To prevent double includes the classes will check if zabbix::repo has already been included.
Instead of checking if the zabbix::repo class should be included (if $manage_repo) the class will be included either way and zabbix::repo will decide if it manages the repositories.