Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #240 #246

Merged
merged 5 commits into from
Jul 18, 2016
Merged

Fix for issue #240 #246

merged 5 commits into from
Jul 18, 2016

Conversation

fgallese
Copy link
Contributor

Here I'm adding a method to check the zabbix agent/server config file defined by the user.

This fix allaws the user to specify a different config file than the standard /etc/zabbix/zabbix_[agentd|server].conf without breaking the installation.

@fgallese
Copy link
Contributor Author

Hello @bastelfreak: Here I'm creating a new clean pull request with the fixes discussed previously.

@bastelfreak
Copy link
Member

Hi,
I think you've to use versioncmp() to fix the remaining linter issues.

@fgallese
Copy link
Contributor Author

@bastelfreak: Thank you. I fixed that and it is now passing all tests.

@bastelfreak
Copy link
Member

\o/

@bastelfreak bastelfreak merged commit 9b34192 into voxpupuli:master Jul 18, 2016
@bastelfreak bastelfreak mentioned this pull request Jul 18, 2016
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants