Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for zabbix::agent on AIX #665

Merged
merged 9 commits into from
Jul 22, 2020
Merged

Conversation

bjschafer
Copy link

Pull Request (PR) description

This initial pass offers support for installing and managing the Zabbix
agent on AIX systems. It has been tested against AIX 7.1 and 7.2.

No support is provided for managing a repo; package installation support
depends on a yum repo being available on the machine.

This Pull Request (PR) fixes the following issues

Fixes #504

manifests/params.pp Outdated Show resolved Hide resolved
Braxton Schafer added 2 commits March 18, 2020 12:41
try and specify package provider for aix

try and better aix

fix service owner

Define package_provider everywhere

To fix failing tests

Support for zabbix::agent on AIX

This initial pass offers support for installing and managing the Zabbix
agent on AIX systems. It has been tested against AIX 7.1 and 7.2.

No support is provided for managing a repo; package installation support
depends on a `yum` repo being available on the machine.
@bjschafer
Copy link
Author

OK, I think the 2 failing tests are unrelated to work I was doing, so I'm marking this as ready for review.

@bjschafer bjschafer marked this pull request as ready for review March 18, 2020 20:13
@bastelfreak bastelfreak added enhancement New feature or request needs-work not ready to merge just yet labels Apr 2, 2020
@vox-pupuli-tasks
Copy link

Dear @bjschafer, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

1 similar comment
@vox-pupuli-tasks
Copy link

Dear @bjschafer, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

Braxton Schafer added 2 commits May 7, 2020 16:37
* foo/master: (30 commits)
  Drop ruby < 2.3 fakefs gem dependency
  Change database collation to utf8_bin as it is stated in official docs
  Install docs on CentOS acceptance tests
  zabbix::web: Allow httpd to speak to the database
  fix acceptance test ordering
  use master branch from rspec-puppet-facts
  Cleanup acceptance test helper
  modulesync 2.12.0
  CentOS tests: Purge whole yum cache
  switch to improved rspec-puppet-facts version
  Add Debian 10 support
  Improve `zabbix_proxy` type
  Improve zabbix_proxy acceptance tests
  Cleanup acceptance test helper
  Changes suggested in PR review
  Fix zbx_macros datatype
  Quotes and commas are unnecessary with %w
  Refactoring of macro implementation
  Add $zbx_macros datatype
  Add support for defining host's macros
  ...
@bjschafer bjschafer requested a review from bastelfreak May 7, 2020 22:11
@bastelfreak
Copy link
Member

@bjschafer thanks for the work! can you please add the os to the metadata.json?

@bjschafer
Copy link
Author

@bastelfreak done -- it looks like in other voxpupuli repos no version is specified with AIX. Is that acceptable here as well?

@vox-pupuli-tasks
Copy link

Dear @bjschafer, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs?
If you need any help, you can reach out to us on our IRC channel voxpupuli on Freenode or our Slack channel voxpupuli at slack.puppet.com.
You can find my sourcecode at voxpupuli/vox-pupuli-tasks

@bastelfreak bastelfreak removed the needs-work not ready to merge just yet label Jul 22, 2020
@bastelfreak bastelfreak added tests-fail and removed enhancement New feature or request labels Jul 22, 2020
@bastelfreak bastelfreak added the enhancement New feature or request label Jul 22, 2020
@bastelfreak bastelfreak merged commit 1846061 into voxpupuli:master Jul 22, 2020
@bjschafer bjschafer deleted the aix-support branch July 22, 2020 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AIX Support
3 participants