Ensure correct logfile/logfilesize values when defaulting logtype to system #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
root-expert
changed the title
root-expert
changed the title
…system Signed-off-by: Christos Papageorgiou <[email protected]>
|
Hopefully that's not backwards incompatible anymore. LogType still defaults to system when systemd is detected, but the other params, LogFile/LogFileSize, have correct default values. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting
logtypeto system ensurelogfileandlogfilesizehave correct values instead ofundef.Chagning logtype to file could lead to non-working agent due to these values being undef, which is not obvious.
This Pull Request (PR) fixes the following issues