Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bootstrap agent2 support #929

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Bootstrap agent2 support #929

merged 1 commit into from
Mar 12, 2024

Conversation

Valantin
Copy link
Contributor

@Valantin Valantin commented Mar 5, 2024 •
edited
Loading

Pull Request (PR) description

This pull Request was a rebase of work in #914 and other

  • Remove some parameters in zabbix agent configuration if it's zabbix agent2 package * LogRemoteCommands * StartAgents * MaxLinesPerSecond * AllowRoot * User * LoadModulePath
  • Fix EnableRemoteCommands still use on zabbix agentd > 5 but remove on agent2

Conflicts:
manifests/agent.pp
spec/classes/agent_spec.rb
templates/zabbix_agentd.conf.erb

This Pull Request (PR) fixes the following issues

Fixes #692

@Phil-Friderici Phil-Friderici mentioned this pull request Mar 6, 2024
Closed
bastelfreak
bastelfreak reviewed Mar 7, 2024
View reviewed changes
manifests/startup.pp Outdated Show resolved Hide resolved
h-haaks
h-haaks reviewed Mar 7, 2024
View reviewed changes
manifests/init.pp Outdated Show resolved Hide resolved
@bastelfreak
Copy link
Member

Please also take a look at https://github.com/voxpupuli/puppet-zabbix/tree/master/spec/acceptance and add an acceptance test for the new agent.

@Valantin Valantin force-pushed the bug-692 branch 8 times, most recently from 8c69188 to 333546c Compare March 7, 2024 11:26
bastelfreak
bastelfreak reviewed Mar 7, 2024
View reviewed changes
manifests/agent.pp Outdated Show resolved Hide resolved
@Valantin Valantin force-pushed the bug-692 branch 6 times, most recently from e4a477d to 8a5bcb0 Compare March 7, 2024 14:32
@Phil-Friderici
Copy link

I'm very happy to see all the activities here now.
If you need help, I can try to work on the unit tests. Let me know.

@Valantin
Copy link
Contributor Author

Valantin commented Mar 7, 2024

I think I've fix the problem, need tro cleanup the agent package like the server package

@Valantin Valantin requested review from bastelfreak and h-haaks March 7, 2024 14:55
@Valantin Valantin force-pushed the bug-692 branch 2 times, most recently from 2961060 to 674cc7f Compare March 8, 2024 12:26
@Valantin Valantin requested a review from bastelfreak March 8, 2024 12:46
@Valantin Valantin force-pushed the bug-692 branch 10 times, most recently from a24599a to 93c7965 Compare March 11, 2024 10:42
@fe80 @Valantin
Bootstrap agent2 support
fde4be3 
* Remove some parameters in zabbix agent configuration if it's zabbix
  agent2 package
    * LogRemoteCommands
    * StartAgents
    * MaxLinesPerSecond
    * AllowRoot
    * User
    * LoadModulePath
* Fix EnableRemoteCommands still use on zabbix agentd > 5 but remove on
  agent2

Conflicts:
	manifests/agent.pp
	spec/classes/agent_spec.rb
	spec/acceptance/agent_spec.rb
	templates/zabbix_agentd.conf.erb
@Valantin Valantin requested a review from bastelfreak March 11, 2024 11:34
@bastelfreak bastelfreak added the enhancement New feature or request label Mar 12, 2024
@bastelfreak bastelfreak merged commit 934afa2 into voxpupuli:master Mar 12, 2024
62 checks passed
@Valantin Valantin deleted the bug-692 branch June 27, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-haaks h-haaks Awaiting requested review from h-haaks

@bastelfreak bastelfreak Awaiting requested review from bastelfreak

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Support for Zabbix Agent 2
5 participants
@Valantin @bastelfreak @Phil-Friderici @h-haaks @fe80