-
-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failed catalog is being showed as unchanged #283
Comments
Can you curl your PuppetDB server for that report and paste the results? You can use, for example: |
[{"catalog_uuid":"982693b6-b6ff-45aa-b5a1-c43cfb42233c","receive_time":"2016-07-29T04:55:48.530Z","hash":"518070ea147f6aed6c3d0e825e0d2382acc006a2","transaction_uuid":"aa247fe5-7c2b-492f-b5b7-587be44f03d1","puppet_version":"4.5.2","noop":false,"logs":{"data":[{"file": null, "line": null, "tags": ["err"], "time": "2016-07-29T07:55:48.105886136+03:00", "level": "err", "source": "Puppet", "message": "Failed to apply catalog: sysctl parameter net.ipv4.conf.eth1.rp_filter wasn't found on this system"}],"href":"/pdb/query/v4/reports/518070ea147f6aed6c3d0e825e0d2382acc006a2/logs"},"report_format":5,"start_time":"2016-07-29T04:54:07.302Z","producer_timestamp":"2016-07-29T04:55:48.406Z","cached_catalog_status":"not_used","end_time":"2016-07-29T04:55:40.998Z","resource_events":{"data":[{"status":"skipped","timestamp":"2016-07-29T07:55:47.55+03:00","resource_type":"Exec","resource_title":"mcollective-restart","property":null,"new_value":null,"old_value":null,"message":null,"file":"/etc/puppetlabs/code/modules/mcollective/manifests/instance.pp","line":89,"containment_path":["Stage[main]","Mcollective::Instance","Exec[mcollective-restart]"],"containing_class":”Mcollective::Instance"}, {"status":"skipped","timestamp":"2016-07-29T07:55:47.135+03:00","resource_type":"Exec","resource_title":"puppet-restart","property":null,"new_value":null,"old_value":null,"message":null,"file":"/etc/puppetlabs/code/modules/puppet4/manifests/agent.pp","line":25,"containment_path":["Stage[main]","Puppet4::Agent","Exec[puppet-restart]"],"containing_class":"Puppet4::Agent"}],"href":"/pdb/query/v4/reports/518070ea147f6aed6c3d0e825e0d2382acc006a2/events"},"status":"unchanged","configuration_version":"88376bcbe930b376061e446bd3eb9d0717761d49","environment":"production","code_id":"88376bcbe930b376061e446bd3eb9d0717761d49","certname":"node1","metrics":{"data":[{"name": "changed", "value": 0, "category": "resources"}, {"name": "failed", "value": 0, "category": "resources"}, {"name": "failed_to_restart", "value": 0, "category": "resources"}, {"name": "out_of_sync", "value": 0, "category": "resources"}, {"name": "restarted", "value": 0, "category": "resources"}, {"name": "scheduled", "value": 0, "category": "resources"}, {"name": "skipped", "value": 2, "category": "resources"}, {"name": "total", "value": 255, "category": "resources"}, {"name": "anchor", "value": 0.000452192, "category": "time"}, {"name": "augeas", "value": 1.1774491679999999, "category": "time"}, {"name": "config_retrieval", "value": 8.456145605, "category": "time"}, {"name": "cron", "value": 0.0008603250000000001, "category": "time"}, {"name": "datacat_collector", "value": 0.005018035, "category": "time"}, {"name": "datacat_fragment", "value": 0.00024012300000000002, "category": "time"}, {"name": "exec", "value": 0.081281991, "category": "time"}, {"name": "file", "value": 0.411121688, "category": "time"}, {"name": "group", "value": 0.00079108, "category": "time"}, {"name": "ini_setting", "value": 0.00449484, "category": "time"}, {"name": "package", "value": 83.33360926299999, "category": "time"}, {"name": "schedule", "value": 0.000233024, "category": "time"}, {"name": "service", "value": 0.219919308, "category": "time"}, {"name": "sysctl", "value": 0.000213649, "category": "time"}, {"name": "total", "value": 93.696391427, "category": "time"}, {"name": "user", "value": 0.0017939420000000002, "category": "time"}, {"name": "yumrepo", "value": 0.002767194, "category": "time"}, {"name": "total", "value": 0, "category": "changes"}, {"name": "failure", "value": 0, "category": "events"}, {"name": "success", "value": 0, "category": "events"}, {"name": "total", "value": 0, "category": "events"}],"href":"/pdb/query/v4/reports/518070ea147f6aed6c3d0e825e0d2382acc006a2/metrics"}}]
|
@corey-hammerton any ideas? |
Sorry for the delay, I have not had a chance to analyze this output as I've had many things on the go over the last couple weeks. I will update this issue when I've had a chance to look at this. |
OK, I've had a chance to look at the catalog JSON. There is indeed an error message in the logs section, I've also noticed a status key value of "unchanged" but this doesn't affect the overall Node or Report status. The easiest thing next to do is submit the raw JSON from the Reports endpoint. Specifically I want to see the |
This is quite misleading. Whatever is behind the macros, the one used on the 'node' and reports page is able to show a run as "failed" where as the 'nodes' page will show unchanged. |
Here is another machine's report. Status is "changed" due to some resources have been applied, but /etc/puppetlabs/code/modules/nginx/manifests/init.pp has not been applied properly. [ |
What puppetboard version do you use, @amuhametov? Because I have this issue too in an old 0.0.4 but I was sure that this has been resolved since then.. |
The latest one.
The problem is related to puppetdb, I suppose.
…On Tue, Jan 10, 2017 at 5:12 PM, Greg Dubicki ***@***.***> wrote:
What puppetboard version do you use, @amuhametov
<https://github.com/amuhametov>? Because I have this issue too in an old
0.0.4 but I was sure that this has been resolved since then..
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#283 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAn1lWTE6Qg19_vX1O53jIMIfsx1JS70ks5rQ5HEgaJpZM4JVFdl>
.
--
Best regards
Anes Mukhametov
|
I think this maybe fixed in PR #342. I'm going to create a test around this using your data provided in earlier posts. |
I saw something similar before updating to pypuppetdb 0.3.2 : I added a node for the first time, but then if the catalog compilation failed, the Overview "Population" counter was incremented (so the new node was known by PuppetDB), but the failed counter wasn't and no failed report was seen. I have just tried the same again now with pypuppetdb 0.3.2 and the latest master puppetboard code, and the problem seems to be gone for me. |
This will be in 0.2.1, just needs some unit tests, to prevent regression. |
Please see my last comment in #449. |
Hi!
I've catalog failed with this error:
https://www.dropbox.com/s/9aklf7b3ncxe9c4/Screenshot%202016-07-26%2015.13.50.png?dl=0
At the same time the node's status is "unchanged":
https://www.dropbox.com/s/pr6qjosqbauquci/Screenshot%202016-07-26%2015.14.34.png?dl=0
I suppose it should be "failed" instead of "unchanged"
The text was updated successfully, but these errors were encountered: