Align structured facts with tops of cells #1086
Conversation
Structured facts are potentially very long, so it can be hard to find the keys and values. This puts them at the top of the cells, which might be less visibly pleasing from a design perspective, but is definitely more useful.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1086 +/- ##
=======================================
Coverage 76.87% 76.87%
=======================================
Files 20 20
Lines 1310 1310
=======================================
Hits 1007 1007
Misses 303 303 ☔ View full report in Codecov by Sentry. |
|
On a Before After |
|
On a Before After |
There was a problem hiding this comment.
Slightly better. Top-alignment of the fact names make sense as some facts are very long and this makes us be sure we can scroll up to read the fact name.
Maybe we improve this further by limiting the height used to display a fact value, maybe "wrapping" long facts values and allowing the user to unwrap them form the UI with a button (look complicated), or limiting the value max height and having a scroll-bar on overflow (full CSS); but it is maybe something for another PR.
If I ever have time, I was thinking about looking into some javascript that could make the structured facts collapsible - no idea when I would get to it... |
|
Thank you for the contribution, @yakatz! Feel free to create your PR to further improve this, @smortex and @bastelfreak 😊 |
Structured facts are potentially very long, so it can be hard to find the keys and values. This puts them at the top of the cells, which might be less visibly pleasing from a design perspective, but is definitely more useful.