Allow to configure enabled query endpoints #477
Conversation
|
@alexjfisher Hi, so nice to see some activity in Puppetboard, thanks a lot! |
Allow to configure which PuppetDB endpoints are allowed in the /query page, adding the ENABLED_QUERY_ENDPOINTS configuration variable, that if set restricts the allowed endpoints to query. If not set the previous behaviour is kept, allowing all PuppetDB endpoints to be queried, if the ENABLE_QUERY configuration is True. Closes: voxpupuli#475
|
I've rebased the branch to the current HEAD of master resolving the conflicts (was just he README migration from |
|
|
||
| if form.endpoints.data == 'pql': | ||
| query = form.query.data | ||
| elif form.query.data[0] == '[': |
There was a problem hiding this comment.
Should this perhaps be form.query.data.strip[0] instead to correctly handle a query with a leading newline/space? I imagine that could happen pretty easily with a textarea field and copy-paste.
There was a problem hiding this comment.
@runejuhl thanks for the review. This was pre-existing code (see line 771 on current code), but I'm happy pass it through strip() if there is an agreement.
There was a problem hiding this comment.
/me toggles the unified diff setting
Sorry about that, you're right of course.
There was a problem hiding this comment.
I think this can stay as it is. But another PR that makes the existing code more beautiful is always highly appreciated.
|
oh and @bastelfreak, thanks for merging and sorting out all the travis related stuff over the weekend! :) |
Allow to configure which PuppetDB endpoints are allowed in the
/querypage, adding the
ENABLED_QUERY_ENDPOINTSconfiguration variable, thatif set restricts the allowed endpoints to query. If not set the previous
behaviour is kept, allowing all PuppetDB endpoints to be queried, if the
ENABLE_QUERYconfiguration isTrue.Closes: #475