Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable Overview page #614

Closed
wants to merge 7 commits into from
Closed

Configurable Overview page #614

wants to merge 7 commits into from

Conversation

gdubicki
Copy link
Contributor

@gdubicki gdubicki commented Mar 19, 2021

Implements #544 and #533.

Firstly I moved the "population" - number of nodes - to the same row as other metrics that show the number of nodes in various states.

Then I added 2 new configuration settings to allow disabling 2 sections of that page:

  • RESOURCES_STATS_ENABLED
  • NODES_STATUS_DETAIL_ENABLED

Both are set to True by default for backward compatibility.

I also organized the docs for all the settings in the README.

@gdubicki
Copy link
Contributor Author

A screenshot showing the updated front page with both sections disabled. Note where the "total population" metric is located now.
Screenshot 2021-03-19 at 22 21 27

@gdubicki gdubicki marked this pull request as ready for review March 19, 2021 21:23
@gdubicki
Copy link
Contributor Author

Hm, I need to fix the tests...

@gdubicki gdubicki marked this pull request as draft March 19, 2021 21:39
@gdubicki gdubicki changed the title Configurable front page Configurable Overview page Mar 19, 2021
@gdubicki
Copy link
Contributor Author

I also forgot to update def index(env), so we still actually get the data that we do not show in the template... 🤦

@gdubicki
Copy link
Contributor Author

Oups, disabling NODES_STATUS_DETAIL_ENABLED breaks failed/pending/changed/unreported metrics...

Copy link
Member

@sebastianrakel sebastianrakel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, but the decreasing test coverage should be fixed

@gdubicki
Copy link
Contributor Author

Thanks @sebastianrakel , but I have to make it work with RESOURCES_STATS_ENABLED=True and NODES_STATUS_DETAIL_ENABLED=False without actually all the processing that would be done if NODES_STATUS_DETAIL_ENABLED=True.

@sebastianrakel
Copy link
Member

After a chat with @gdubicki, we will close this pull request in favor of #639

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants