Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add download as CSV/XLSX to Query results + update static assets #654

Merged
merged 1 commit into from
Jan 19, 2022

Conversation

gdubicki
Copy link
Contributor

@gdubicki gdubicki commented Dec 29, 2021

Additionally update jQuery and other JS & CSS related to DataTables.

view. Additionally update jQuery and other JS & CSS
related to DataTables.
@gdubicki gdubicki changed the title To csv Add download as CSV/XLSX to Query results Jan 15, 2022
@codecov
Copy link

codecov bot commented Jan 15, 2022

Codecov Report

Merging #654 (9585a88) into master (f3d3838) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #654      +/-   ##
==========================================
+ Coverage   82.72%   82.77%   +0.05%     
==========================================
  Files          12       12              
  Lines         897      900       +3     
==========================================
+ Hits          742      745       +3     
  Misses        155      155              
Impacted Files Coverage Δ
puppetboard/app.py 78.36% <100.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3d3838...9585a88. Read the comment docs.

@gdubicki gdubicki marked this pull request as ready for review January 15, 2022 15:31
@gdubicki
Copy link
Contributor Author

This is how the buttons and query results in non-JSON mode will look:

Screenshot 2022-01-15 at 15 31 32

@gdubicki
Copy link
Contributor Author

gdubicki commented Jan 15, 2022

This partially implements #428 and #30. Extending it to cover all the tables can be added in another PR and I would be happy if someone else would like to do it. :)

Copy link
Member

@bastelfreak bastelfreak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updating the static files doe not relate to the new feature? please put that into a dedicated PR. Do you have any semiautomatic way for updating the files? If so, please document that.

@gdubicki
Copy link
Contributor Author

gdubicki commented Jan 16, 2022

updating the static files doe not relate to the new feature? please put that into a dedicated PR. Do you have any semiautomatic way for updating the files? If so, please document that.

That request makes a lot of sense and normally I would totally agree.

However as I was adding a new feature that is using a new library I have added it in the latest stable version. And to avoid compatibility issues I updated the related libraries too.

Theoretically I could downgrade Datatables Buttons to a version compatible with the version of Datatables that we had before the upgrade but I don't even know which that is - they are versioned separately and the website doesn't allow choosing older versions on their download page.

Because of that and because we didn't upgrade any major version here, I think that we can keep this change in this PR.

PS And no, sadly I don't have any automation for the libs update. I just find them on https://cdnjs.com/, get the code to put it into the templates + wget the files themselves to add them to the repo as statics.

@bastelfreak bastelfreak changed the title Add download as CSV/XLSX to Query results Add download as CSV/XLSX to Query results + update static assets Jan 19, 2022
@gdubicki gdubicki merged commit c34f65b into master Jan 19, 2022
@gdubicki gdubicki deleted the to_csv branch January 19, 2022 10:40
allan-reynolds added a commit to allan-reynolds/puppetboard that referenced this pull request Apr 21, 2022
This fixes the links to jquery again.
See also voxpupuli@af87dc2 (for previous instance) voxpupuli#654 (for regression introduction)
gdubicki pushed a commit that referenced this pull request Apr 21, 2022
This fixes the links to jquery again.
See also af87dc2 (for previous instance) #654 (for regression introduction)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants