-
-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add download as CSV/XLSX to Query results + update static assets #654
Conversation
view. Additionally update jQuery and other JS & CSS related to DataTables.
Codecov Report
@@ Coverage Diff @@
## master #654 +/- ##
==========================================
+ Coverage 82.72% 82.77% +0.05%
==========================================
Files 12 12
Lines 897 900 +3
==========================================
+ Hits 742 745 +3
Misses 155 155
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updating the static files doe not relate to the new feature? please put that into a dedicated PR. Do you have any semiautomatic way for updating the files? If so, please document that.
That request makes a lot of sense and normally I would totally agree. However as I was adding a new feature that is using a new library I have added it in the latest stable version. And to avoid compatibility issues I updated the related libraries too. Theoretically I could downgrade Datatables Buttons to a version compatible with the version of Datatables that we had before the upgrade but I don't even know which that is - they are versioned separately and the website doesn't allow choosing older versions on their download page. Because of that and because we didn't upgrade any major version here, I think that we can keep this change in this PR. PS And no, sadly I don't have any automation for the libs update. I just find them on https://cdnjs.com/, get the code to put it into the templates + |
This fixes the links to jquery again. See also voxpupuli@af87dc2 (for previous instance) voxpupuli#654 (for regression introduction)
Additionally update jQuery and other JS & CSS related to DataTables.