Failures view #662
Merged
Failures view #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's totally unfinished, including the UI & UX, but it would very roughly look like this:
|
|
This looks like an amazing addition!
Get Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: Greg Dubicki ***@***.***>
Sent: Friday, February 18, 2022 3:48:27 AM
To: voxpupuli/puppetboard ***@***.***>
Cc: Subscribed ***@***.***>
Subject: Re: [voxpupuli/puppetboard] Failures view (PR #662)
CAUTION: This email originated from outside your organization. Exercise caution when opening attachments or on clicking links from unknown senders.
It's totally unfinished, including the UI & UX, but would very roughly look like this:
[Screenshot_2022-02-18_at_08_44_38]<https://user-images.githubusercontent.com/566632/154649178-bab2a75d-ef19-40dc-b19f-b0bee31a4a8e.png>
—
Reply to this email directly, view it on GitHub<#662 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABJYF5TR67EHRFEEDEHGHE3U3YBVXANCNFSM5OWCGPMQ>.
Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
gdubicki
force-pushed
the
failures_view
branch
2 times, most recently
from
e9e9481 to
dace401
Compare
Codecov Report
@@ Coverage Diff @@
## master #662 +/- ##
==========================================
- Coverage 88.32% 84.09% -4.23%
==========================================
Files 18 19 +1
Lines 959 1031 +72
==========================================
+ Hits 847 867 +20
- Misses 112 164 +52
Continue to review full report at Codecov.
|
|
For a long time now I was thinking that Puppet's error messages can and should be improved. They contain a lot of redundancy, are not well formatted for readability. Therefore I added a feature for it here. I would like to optionally make it available in the report view too, while doing #641. Example "raw" error:
...and its "friendly" version:
Opinions? |
|
Current looks of the failures page:
|
- first error on each node with the last puppet run failed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft of a new view that would help finding the most common errors in puppet runs to resolve them faster.
To do that it would list all the nodes with errors in their last puppet run and for each of them show the first meaningful error in it.