Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Report view #686

Merged
merged 15 commits into from
May 16, 2022
Merged

Better Report view #686

merged 15 commits into from
May 16, 2022

Conversation

gdubicki
Copy link
Contributor

@gdubicki gdubicki commented May 14, 2022

This will implement/fix: #481, #641, #685.

Major changes:

  • move Logs before Events as it's more useful,
  • show different, arguably more useful columns in Logs by default,
  • allow showing messages in the "friendly" mode,
  • make Logs and Events filterable,
  • don't force column sizes for a better, automatic content layout,
  • use fixed-width font where it makes more sense,

@codecov
Copy link

codecov bot commented May 14, 2022

Codecov Report

Merging #686 (575ab3e) into master (1b165f0) will increase coverage by 0.80%.
The diff coverage is 64.15%.

❗ Current head 575ab3e differs from pull request most recent head 2e88889. Consider uploading reports for the commit 2e88889 to get more accurate results

@@            Coverage Diff             @@
##           master     #686      +/-   ##
==========================================
+ Coverage   85.49%   86.29%   +0.80%     
==========================================
  Files          19       19              
  Lines        1034     1051      +17     
==========================================
+ Hits          884      907      +23     
+ Misses        150      144       -6     
Impacted Files Coverage Δ
puppetboard/views/reports.py 64.70% <57.14%> (+10.08%) ⬆️
puppetboard/core.py 85.71% <65.51%> (-14.29%) ⬇️
puppetboard/default_settings.py 100.00% <100.00%> (ø)
puppetboard/version.py 100.00% <100.00%> (ø)
puppetboard/views/failures.py 28.94% <100.00%> (-15.83%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b165f0...2e88889. Read the comment docs.

@gdubicki
Copy link
Contributor Author

gdubicki commented May 15, 2022

Logs before:

Screenshot 2022-05-15 at 21 39 50

Logs after:

Screenshot 2022-05-15 at 21 39 34

@gdubicki
Copy link
Contributor Author

gdubicki commented May 15, 2022

TODO:

  • remove tripled messaged from notify {} - nah, not in this PR,
  • hide level column too - colors show the level - nah, level can be very useful for filtering,
  • remove millisecond precision in timestamp - it’s information overload,

...and some (other) tweaks.

@gdubicki gdubicki marked this pull request as ready for review May 16, 2022 20:34
@gdubicki gdubicki merged commit 917c95e into master May 16, 2022
@gdubicki gdubicki deleted the better_report branch May 16, 2022 20:41
@gdubicki
Copy link
Contributor Author

Thanks @bastelfreak! I would like to release this within a few days, after some time of RC testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter report messages
2 participants