Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run health check more cleanly and more often #690

Merged
merged 1 commit into from
Jun 6, 2022
Merged

Run health check more cleanly and more often #690

merged 1 commit into from
Jun 6, 2022

Conversation

jcpunk
Copy link
Contributor

@jcpunk jcpunk commented Jun 1, 2022

In theory this should be right....

@codecov
Copy link

codecov bot commented Jun 1, 2022

Codecov Report

Merging #690 (27b61f1) into master (428d05b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #690   +/-   ##
=======================================
  Coverage   86.31%   86.31%           
=======================================
  Files          19       19           
  Lines        1052     1052           
=======================================
  Hits          908      908           
  Misses        144      144           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 428d05b...27b61f1. Read the comment docs.

@gdubicki
Copy link
Contributor

gdubicki commented Jun 6, 2022

Yeah, it works now.

CONTAINER ID   IMAGE         COMMAND                  CREATED              STATUS                        PORTS     NAMES
7a056c872cf2   puppetboard   "/bin/sh -c 'gunicor…"   About a minute ago   Up About a minute (healthy)   80/tcp    epic_raman

Thanks!

@gdubicki gdubicki merged commit 92fc683 into voxpupuli:master Jun 6, 2022
@jcpunk jcpunk deleted the fix-health branch June 6, 2022 15:23
@jcpunk
Copy link
Contributor Author

jcpunk commented Jun 6, 2022

Excellent! any chance for a new container image?

@gdubicki
Copy link
Contributor

gdubicki commented Jun 6, 2022

Sure, but I would like to wait a day or two for #692 and release these together.

@jcpunk
Copy link
Contributor Author

jcpunk commented Jun 6, 2022

Works for me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants