command_path config parameter not honored #152
Comments
genebean
added a commit
to genebean/webhook-go
that referenced
this issue
May 1, 2024
Prior to this, the Config struct had a setting under the R10k struct called CommandPath that could be set in the config file, but was ignored as both places that would use it were hard coded to instead use the string `r10k`. This resulted in the application looking in the path for the r10k binary. A default is set in config.go also, but that seems to have also been ignored. This fixes voxpupuli#152
genebean
added a commit
to genebean/webhook-go
that referenced
this issue
May 7, 2024
Prior to this, the Config struct had a setting under the R10k struct called CommandPath that could be set in the config file, but was ignored as both places that would use it were hard coded to instead use the string `r10k`. This resulted in the application looking in the path for the r10k binary. A default is set in config.go also, but that seems to have also been ignored. This fixes voxpupuli#152
genebean
added a commit
to genebean/webhook-go
that referenced
this issue
May 7, 2024
Prior to this, the Config struct had a setting under the R10k struct called CommandPath that could be set in the config file, but was ignored as both places that would use it were hard coded to instead use the string `r10k`. This resulted in the application looking in the path for the r10k binary. A default is set in config.go also, but that seems to have also been ignored. This fixes voxpupuli#152
dhollinger
pushed a commit
that referenced
this issue
May 8, 2024
Prior to this, the Config struct had a setting under the R10k struct called CommandPath that could be set in the config file, but was ignored as both places that would use it were hard coded to instead use the string `r10k`. This resulted in the application looking in the path for the r10k binary. A default is set in config.go also, but that seems to have also been ignored. This fixes #152
dhollinger
pushed a commit
that referenced
this issue
May 8, 2024
Prior to this, the Config struct had a setting under the R10k struct called CommandPath that could be set in the config file, but was ignored as both places that would use it were hard coded to instead use the string `r10k`. This resulted in the application looking in the path for the r10k binary. A default is set in config.go also, but that seems to have also been ignored. This fixes #152
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It seems that the config option
command_pathfor r10k is not honored. I tried setting it in version 2.3.0 but the server saidexec: "r10k": executable file not found in $PATH, which is actually accurate in that the specified r10k executable is not in my path. I looked through the code and it seems to me that a helper is needed to parse out that config setting. I am working on a PR for this now.The text was updated successfully, but these errors were encountered: