Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/refactor to fluent interface #29

Merged
merged 15 commits into from
Dec 2, 2022

Conversation

momo-the-monster
Copy link
Contributor

@momo-the-monster momo-the-monster commented Nov 23, 2022

  • Adds new Fluent Interface with test coverage matching the original SpecTests and updated documentation.
  • Also advertises using the computer's actual IP instead of 'localhost'.

Details on the implementation added to the Getting Started page as part of this PR.

vrc-oscquery-lib/OSCQueryService.cs Outdated Show resolved Hide resolved
vrc-oscquery-lib/OSCQueryService.cs Outdated Show resolved Hide resolved
vrc-oscquery-lib/OSCQueryServiceBuilder.cs Show resolved Hide resolved
Also renames OscPort to UdpPort for consistency
So we don't call WithDefaults() again if the user has already done it.
@momo-the-monster momo-the-monster merged commit 1166c57 into main Dec 2, 2022
@momo-the-monster momo-the-monster deleted the feature/refactor-to-fluent-interface branch December 2, 2022 17:46
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants