New icons, png and svg versions

[dreadnaut]

Hello there, thank you for keeping Permit Cookies up to date!

Would you be interested in new icons for the addon? They come in two sizes, for both the addon or navigation bar and the new Australis menu, and they should easier to tell apart for people with colour blindness.

The svg sources are stored in a new icons/ directory.

[vrillusions]

Thanks for the pull request. Been meaning to do this myself. I like the app icon but for the enabled/disabled icons I'd like to keep them the same just higher resolution in keeping with the not changing stuff unless necessary. The current status icons indeed look pretty bad anywhere but the addon bar. If you remade those then I'd be all for accepting them.

[dreadnaut]

The icons in the existing set are not differentiated enough, and they base most of their contrast on red-green colours. This is a problem for those affected by partial or complete color blindness, as the comparison below shows:

I am happy to tweak the design, but the icons should include some shape variations.

[vrillusions]

So I've been thinking about this, probably more than I need to. The problem is with the curmudgeons like me where something changes and it's the end of the universe. See the whole Australis discussion. As you can imagine I always had tabs under the url bar and when Australis forced it to the top I instead went with tree style tab and even the official recommendation for permit cookies is to install the addon bar extension to put the icon there. But I digress.

So the only logical conclusion then is to let the user decide which icon they want. Thus I created the v2.0 milestone to make it obvious that things have changed. This also allows me to do other things that have been bugging me like the config item not having the extension.pcookie prefix like it should.

I have yet to set a date for v2.0 and I tend to be slow moving on these things and When It's Done™ is not a valid date :)

[dreadnaut]

Tabs under the address bar, for as long as I can.

For the moment, I have redrawn the original 'C' as close as possible and added a 32px set. Now that I think about it, maybe I should send it as a separate changeset —but let me know if it's acceptable!

[vrillusions]

Actually the original icon set I did already ( #8 ) though it's in the 2.0.0 development branch and I didn't mention in commit (0f07d19). Once I figure out how I'll handle this I may ask for a rebase against DEV-2.0.0 but that's probably going to be A While From Now™. Interestingly the "theme" stuff in directory structure is only meant for different environments (so a different icon set in os x for example). So have an idea on how to handle it just need to set things up.

TL;DR: the original version is done already.

[dreadnaut]

Oh, I see. I was tracking master and didn't notice the other branch.

[vrillusions]

Finished the new skin code. How it works (currently although may change it):

• defaults to 'classic' (what it has been)
• in prefs there's a radio box to choose which skin you want.

Still need to do some cleanup before I push it out to mozilla but at least there's finally progress. Thanks for being patient.