Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cli): turn off the default auto-install-dependencies #20

Merged
merged 2 commits into from
Apr 7, 2022

Conversation

Cphayim
Copy link
Member

@Cphayim Cphayim commented Apr 5, 2022

resolve #19

No longer pass autoinstall dependencies to presetRunner by default
Can manually enable it via the -i or --auto-install-deps options

@Cphayim Cphayim requested a review from Hoyoe April 5, 2022 16:39
@codecov
Copy link

codecov bot commented Apr 5, 2022

Codecov Report

Merging #20 (812ecbb) into main (9051289) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #20   +/-   ##
=======================================
  Coverage   98.06%   98.06%           
=======================================
  Files          32       32           
  Lines        2015     2015           
  Branches      168      168           
=======================================
  Hits         1976     1976           
  Misses         37       37           
  Partials        2        2           
Impacted Files Coverage Δ
...s/command-boilerplate/src/create/create.command.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac16e9a...812ecbb. Read the comment docs.

@Cphayim Cphayim merged commit b995c64 into main Apr 7, 2022
@Cphayim Cphayim deleted the refactor/no-auto-i-deps branch April 7, 2022 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

turn off the default auto-install-dependencies
2 participants