Update CoreNodeRenderer.java #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Render node ids if explicitly set fixes vsch#476
|
@jochenberger, thank you for the PR. It will be in the next release. |
|
After taking a closer look and running tests, I realized that this needs a bit of clarification. So I reverted it. Main question is: why do you not have When rendering anchor links for headers, header ids are not rendered because the id is transferred to the anchor link. Otherwise, you get two elements with the same ID. What issue are you having with the current implementation, if you enable |
|
I think the answer is in #476. I'm trying to assign IDs with the attributes extension, but they are not being rendered. |
travkin79
pushed a commit
to advantest/flexmark-java
that referenced
this pull request
Jun 3, 2024
Update CoreNodeRenderer.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Render node ids if explicitly set
fixes #476