common bazel cxx toolchain for Linux and Mac #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the updates, I was able to get parts of |
melindalu
reviewed
Aug 3, 2017
README.md
Outdated
| ## Prequisites |
There was a problem hiding this comment.
I think that prequisite might not be a word
melindalu
reviewed
Aug 3, 2017
scripts/chromium_repo.py
Outdated
| response = requests.get(url, stream=stream) | ||
| if response.status_code != 200: | ||
| print >> sys.stderr, "Unexpected status code", response.status_code | ||
| raise |
There was a problem hiding this comment.
do you want to raise a specific exception here? (Python might fail on no argument here)
melindalu
approved these changes
Aug 3, 2017
|
After removing the health-check code from Was able to successfully build prediction-api on OSX! 🎉 🎉 🎉 🎉 |
promiseofcake
approved these changes
Aug 3, 2017
vladlosev
reviewed
Aug 9, 2017
| TEST(CompilerMeta, AppleBuild) { | ||
| #if defined(__apple_build_version__) | ||
| // __apple_build_version__ shouldn't be defined in the Chromium toolchain | ||
| ASSERT_TRUE(false); |
There was a problem hiding this comment.
BTW, gtest has a FAIL() macro just for such a case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://travis-ci.com/vsco/bazel-toolchains/builds/50882186
Still some cleanup to do:
not sure I'm getting a clean link on linux (should be using the sysroot on the link line).give scripts/generate_workspace.py an arg parsergo through the visibility rules under tools/ (they are all public rn)doesn't use the Chromium copy of libc++ on mac, but I don't think Chromium does either.[edit: this is a lie. we need to use their tree's copy of libc++ too. https://docs.google.com/document/d/1cFVCLYqpVV0pn2aX09SALcE3BN351sFN_rTcPcHRg3U/edit#]
only used on linux: https://cs.chromium.org/chromium/src/build/config/c%2B%2B/c%2B%2B.gni?type=cs&q=use_custom_libcxx&l=11