-
-
Notifications
You must be signed in to change notification settings - Fork 951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Support for AngularDart plus extensions #1863
Added Support for AngularDart plus extensions #1863
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1863 +/- ##
======================================
Coverage 100% 100%
======================================
Files 75 75
Lines 5625 5625
Branches 220 220
======================================
Hits 5625 5625
Continue to review full report at Codecov.
|
As @robertohuertasm mentioned here AngularDart icon is not necessary and better remove it. |
Also to prevent future conflicts the names should be using the |
Okay, I will rename it as soon as I get time, same goes for removing the AngularDart one 👍
Ah, basically place it at the limits of the shield without hidding the horizontal line. Gonna try shrinking the Dart logo to see how it looks but I am afraid of it being too small to be distinguishable. |
@robertohuertasm is your man. He created the |
Great job @KingDarBoja with those |
Fixes #1861
Changes proposed:
Just added the Dart icon at the right bottom side of the current angular icons. I still provided all of them just in case. The little white line behind the Dart icon was to give it a slighty difference with the big Angular one when having same colours as happens with the ng_service one.