Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Support for AngularDart plus extensions #1863

Merged
merged 5 commits into from
Feb 17, 2019

Conversation

KingDarBoja
Copy link
Member

Fixes #1861

Changes proposed:

  • Add
  • Delete
  • Fix
  • Prepare

Just added the Dart icon at the right bottom side of the current angular icons. I still provided all of them just in case. The little white line behind the Dart icon was to give it a slighty difference with the big Angular one when having same colours as happens with the ng_service one.

@codecov
Copy link

codecov bot commented Feb 4, 2019

Codecov Report

Merging #1863 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1863   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          75      75           
  Lines        5625    5625           
  Branches      220     220           
======================================
  Hits         5625    5625
Impacted Files Coverage Δ
src/iconsManifest/supportedExtensions.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f59236d...9511786. Read the comment docs.

@JimiC
Copy link
Member

JimiC commented Feb 4, 2019

As @robertohuertasm mentioned here AngularDart icon is not necessary and better remove it.
The icons need adjustments to the dart icon. Specifically, the guideline is that the icon should not pass over the horizontal line of the letter A but it can extend to the bottom-right up to the 'shield' outer limits.

@JimiC
Copy link
Member

JimiC commented Feb 4, 2019

Also to prevent future conflicts the names should be using the dart word instead of dt (i.e. ng_component_dart). The reasoning is that the file extension is dart and not dt.

@KingDarBoja
Copy link
Member Author

Also to prevent future conflicts the names should be using the dart word instead of dt (i.e. ng_component_dart). The reasoning is that the file extension is dart and not dt.

Okay, I will rename it as soon as I get time, same goes for removing the AngularDart one 👍

As @robertohuertasm mentioned here AngularDart icon is not necessary and better remove it.
The icons need adjustments to the dart icon. Specifically, the guideline is that the icon should not pass over the horizontal line of the letter A but it can extend to the bottom-right up to the 'shield' outer limits.

Ah, basically place it at the limits of the shield without hidding the horizontal line. Gonna try shrinking the Dart logo to see how it looks but I am afraid of it being too small to be distinguishable.

@JimiC
Copy link
Member

JimiC commented Feb 4, 2019

@robertohuertasm is your man. He created the Angular icons in the first place.

@robertohuertasm robertohuertasm added this to the Next milestone Feb 10, 2019
@robertohuertasm robertohuertasm merged commit f5d9a53 into vscode-icons:master Feb 17, 2019
@robertohuertasm
Copy link
Member

Great job @KingDarBoja with those dart icons!

@KingDarBoja KingDarBoja deleted the angulardart-icons branch February 17, 2019 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants