-
-
Notifications
You must be signed in to change notification settings - Fork 951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for modules folder #1985
Add support for modules folder #1985
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1985 +/- ##
======================================
Coverage 100% 100%
======================================
Files 78 78
Lines 5914 5914
Branches 137 137
======================================
Hits 5914 5914
Continue to review full report at Codecov.
|
I'm not 100% OK with the icon or the colors (something is bothering on it but I can't pinpoint it yet) but if the team agrees I'm OK with it. |
Feel free to change the colors. Regarding the icon, I think it was a proper choice because couldn't think anything for modules besides multiple boxes linked together... unless it is better for shared folder icon? |
Personally, I don't dislike the icon. What I think is that the color combination is not the kind of combinations that we usually use. Normally we grab the color of the icon as a base for the color of the folder, but in this case I guess you chose a complementary. I would make it more monochromatic and choose whether purple or yellow as the base color for everything. |
@robertohuertasm I am working on it right now using the steps provided by JimiC on the other PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but let's wait for @JimiC's input and see if we have consensus.
Looking at this in detail I believe the best course is to bind |
Certainly, the components icon could also work for modules. But since we already have this cool icon I don't see a reason not to use it. Components folder has a specific meaning in the UI world and modules seems to me more of a backend construct, so I wouldn't mind having two separated icons. |
OK. I'm going to fix the contrast a bit. Don't merge yet. |
I decided to leave the contrast as is. Will iterate on them if any issue arises. |
References #650
Changes proposed:
This is a proposal for
modules
folder using the icon provided at #1022. Thoughts?