Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for modules folder #1985

Merged
merged 5 commits into from
Apr 21, 2019

Conversation

KingDarBoja
Copy link
Member

@KingDarBoja KingDarBoja commented Apr 19, 2019

References #650

Changes proposed:

  • Add
  • Delete
  • Fix
  • Prepare

This is a proposal for modules folder using the icon provided at #1022. Thoughts?

@codecov
Copy link

codecov bot commented Apr 19, 2019

Codecov Report

Merging #1985 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1985   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          78      78           
  Lines        5914    5914           
  Branches      137     137           
======================================
  Hits         5914    5914
Impacted Files Coverage Δ
src/iconsManifest/supportedFolders.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03035d8...53c4b77. Read the comment docs.

@JimiC JimiC added this to the Next milestone Apr 20, 2019
@JimiC
Copy link
Member

JimiC commented Apr 20, 2019

I'm not 100% OK with the icon or the colors (something is bothering on it but I can't pinpoint it yet) but if the team agrees I'm OK with it.

@KingDarBoja
Copy link
Member Author

I'm not 100% OK with the icon or the colors (something is bothering on it but I can't pinpoint it yet) but if the team agrees I'm OK with it.

Feel free to change the colors. Regarding the icon, I think it was a proper choice because couldn't think anything for modules besides multiple boxes linked together... unless it is better for shared folder icon?

@robertohuertasm
Copy link
Member

robertohuertasm commented Apr 20, 2019

Personally, I don't dislike the icon. What I think is that the color combination is not the kind of combinations that we usually use. Normally we grab the color of the icon as a base for the color of the folder, but in this case I guess you chose a complementary.

I would make it more monochromatic and choose whether purple or yellow as the base color for everything.

@KingDarBoja
Copy link
Member Author

@robertohuertasm I am working on it right now using the steps provided by JimiC on the other PR.

Copy link
Member

@robertohuertasm robertohuertasm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but let's wait for @JimiC's input and see if we have consensus.

@JimiC
Copy link
Member

JimiC commented Apr 21, 2019

Looking at this in detail I believe the best course is to bind modules with the existing components folder icon. After all modules and components are similar in concept.

@robertohuertasm
Copy link
Member

robertohuertasm commented Apr 21, 2019

Certainly, the components icon could also work for modules. But since we already have this cool icon I don't see a reason not to use it. Components folder has a specific meaning in the UI world and modules seems to me more of a backend construct, so I wouldn't mind having two separated icons.

@JimiC
Copy link
Member

JimiC commented Apr 21, 2019

OK. I'm going to fix the contrast a bit. Don't merge yet.

@JimiC
Copy link
Member

JimiC commented Apr 21, 2019

I decided to leave the contrast as is. Will iterate on them if any issue arises.

@robertohuertasm robertohuertasm merged commit 63f2b43 into vscode-icons:master Apr 21, 2019
@KingDarBoja KingDarBoja deleted the module-folder-icon branch June 23, 2019 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants