Icon xliff #317
Merged
Icon xliff #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the XLIFF icon references to `icons.json`.
This adds a globe icon, which can be used for XLIFF files. Icons made by [Freepik](http://www.flaticon.com/authors/freepik "Freepik") from [www.flaticon.com](http://www.flaticon.com "Flaticon") is licensed by [CC 3.0 BY](http://creativecommons.org/licenses/by/3.0/ "Creative Commons BY 3.0")
jens1o
requested changes
Sep 16, 2016
jens1o
requested changes
Sep 16, 2016
New icon additions will be made to `supportedExtensions.js`.
Removes some remnant commas from the previous edit.
Adds the XLIFF globe icon for .xliff and .xlf files.
jens1o
approved these changes
Sep 16, 2016
|
Ha. I am not in friendship with this new github feature, I cannot correct myself... Okey, then the updated icon is left. |
Deletes the file, so the correct, edited one can be put in place.
Adds the correct XLIFF icon with the 2px margin and the icon shifted lower by 1px.
|
@jens1o I've made the requested changes. What's the next step in this new GitHub reviews way? |
|
@jens1o Yeah, it's a bit confusing. I've added the icon as well now. |
|
Perfect, our way to go! Will be merged as soon as @robertohuertasm is there 😄 |
|
@jens1o Awesome! :party: |
jens1o
approved these changes
Sep 16, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_Fixes #316_
Changes proposed:
Things I've done:
npm installto install all the dependeniesnpm run buildto build the extension. (If I had done something with the extension.)Adds the globe icon for the XLIFF language translation format files.
Icons made by Freepik from www.flaticon.com is licensed by CC 3.0 BY