Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for point cloud library (pcd). #992

Merged
merged 2 commits into from
Jun 3, 2017
Merged

Add support for point cloud library (pcd). #992

merged 2 commits into from
Jun 3, 2017

Conversation

JimiC
Copy link
Member

@JimiC JimiC commented Jun 3, 2017 •
edited
Loading

Fixes #917

Changes proposed:

  • Add

Things I've done:

  • My pull request fixes an issue, I referenced the issue.

@JimiC JimiC requested review from robertohuertasm and jens1o June 3, 2017 10:34
jens1o
jens1o approved these changes Jun 3, 2017
View reviewed changes
Copy link
Member

@jens1o jens1o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks god for email notification.

@codecov
Copy link

codecov bot commented Jun 3, 2017 •
edited
Loading

Codecov Report

Merging #992 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #992   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          44     44           
  Lines        2110   2110           
  Branches       99     99           
=====================================
  Hits         2110   2110
Impacted Files Coverage Δ
src/icon-manifest/supportedExtensions.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6df1a65...8167b66. Read the comment docs.

@robertohuertasm robertohuertasm merged commit fac3b38 into vscode-icons:master Jun 3, 2017
@JimiC JimiC deleted the support_pointclouds branch June 3, 2017 18:42
@robertohuertasm robertohuertasm modified the milestone: Next Jun 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertohuertasm robertohuertasm robertohuertasm approved these changes

@jens1o jens1o jens1o approved these changes

Assignees
No one assigned
Labels
file icons
Projects
None yet
Milestone
7.9.0
Development

Successfully merging this pull request may close these issues.

Support for .pcd files
3 participants
@JimiC @robertohuertasm @jens1o