Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payment Provider Protocol API (KR5) #1058

Merged
merged 12 commits into from
Dec 11, 2023

Conversation

ricardoaerobr
Copy link
Contributor

Types of changes

  • New content (endpoints, descriptions or fields from scratch)
  • Improvement (make an endpoint's title or description even better)
  • Spelling and grammar accuracy (self-explanatory)

Changelog

Do not forget to update your changes to our Developer Portal's changelog. Did you create a release note?

  • Yes, I already created a release note about this change.
  • No, but I am going to.

PR created to update Payment Provider Protocol API (KR5) (EDU-10345).

Copy link

Thanks for your contribution. The .json file will be checked now with Spectral.

@ricardoaerobr ricardoaerobr changed the title Update API Index_Permissions_Security_Parameters Payment Provider Protocol API (KR5) Dec 1, 2023
@ricardoaerobr ricardoaerobr marked this pull request as ready for review December 4, 2023 14:38
Copy link
Contributor

@PedroAntunesCosta PedroAntunesCosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It took me some time to understand that the Payment flow endpoints are related to the shopping experience, but the Configuration flow ones are related to the merchant's experience. I think it would be good to add more context and details about the way each endpoint should be used.

Also don't forget to check Spectral comments and solve branch conflicts.

VTEX - Payment Provider Protocol.json Outdated Show resolved Hide resolved
VTEX - Payment Provider Protocol.json Show resolved Hide resolved
VTEX - Payment Provider Protocol.json Outdated Show resolved Hide resolved
VTEX - Payment Provider Protocol.json Outdated Show resolved Hide resolved
VTEX - Payment Provider Protocol.json Outdated Show resolved Hide resolved
VTEX - Payment Provider Protocol.json Outdated Show resolved Hide resolved
VTEX - Payment Provider Protocol.json Outdated Show resolved Hide resolved
VTEX - Payment Provider Protocol.json Outdated Show resolved Hide resolved
VTEX - Payment Provider Protocol.json Outdated Show resolved Hide resolved
VTEX - Payment Provider Protocol.json Outdated Show resolved Hide resolved
Copy link
Contributor

@PedroAntunesCosta PedroAntunesCosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ricardoaerobr ricardoaerobr merged commit c69b40b into master Dec 11, 2023
1 of 2 checks passed
@ricardoaerobr ricardoaerobr deleted the 23H2KR5---Payment-Provider-Protocol branch December 11, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants