Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ad network integration #1367

Merged
merged 17 commits into from
Jan 29, 2025
Merged

ad network integration #1367

merged 17 commits into from
Jan 29, 2025

Conversation

julia-rabello
Copy link
Contributor

@julia-rabello julia-rabello commented Jan 7, 2025

adding endpoints and parameters used in ad network integrations to support documentation that will be created as part of EDU-14044

Types of changes

  • New content (endpoints, descriptions or fields from scratch)
  • Improvement (make an endpoint's title or description even better)
  • Spelling and grammar accuracy (self-explanatory)

Changelog

Do not forget to update your changes to our Developer Portal's changelog. Did you create a release note?

  • Yes, I already created a release note about this change.
  • No, but I am going to.

@julia-rabello julia-rabello changed the title Ad-network-integration ad network integration Jan 7, 2025
@julia-rabello julia-rabello self-assigned this Jan 7, 2025
Copy link

github-actions bot commented Jan 7, 2025

Thanks for your contribution. The .json file will be checked now with Spectral.

@julia-rabello julia-rabello requested a review from fltiago January 7, 2025 23:17
@julia-rabello julia-rabello marked this pull request as ready for review January 7, 2025 23:17
@julia-rabello julia-rabello requested a review from a team January 21, 2025 13:13
fltiago
fltiago previously approved these changes Jan 29, 2025
Copy link
Contributor

@fltiago fltiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excelente!

Co-authored-by: Isabella Veloso Sá <[email protected]>
Copy link
Contributor

@Isabella-Veloso Isabella-Veloso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request changes

Copy link
Contributor

@Isabella-Veloso Isabella-Veloso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@julia-rabello julia-rabello merged commit 7543cad into master Jan 29, 2025
3 of 4 checks passed
@julia-rabello julia-rabello deleted the ad-network-integration branch January 29, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants