Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial setup for devcontainers for OSE project #556

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Rughalt
Copy link
Collaborator

@Rughalt Rughalt commented Jan 10, 2025

This PR adds a simple devcontainer setup that simplifies setting up a development environment.

To use this, you need docker and an editor that supports running devcontainers (or running them locally).

@Rughalt Rughalt linked an issue Jan 10, 2025 that may be closed by this pull request
1 task
Copy link
Collaborator

@wyrmisis wyrmisis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple questions for a quick review. I'd need to run this before I can approve it. Could you add some notes to the contributing file for how to run it?

Comment on lines +8 to +10
"ghcr.io/duduribeiro/devcontainer-features/neovim:1": {
"version": "nightly"
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if there's a way to add LazyVim or Astro to this config?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We ought to prompt for a license key, too, or have some way to easily pull it from somewhere.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can open Foundry then using the provided launch.json (or just by running a command in the devcontainer) and it will ask you for serial number. I don't know how to provide it differently, but I will take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify development environment setup for the project
2 participants