-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial setup for devcontainers for OSE project #556
base: main
Are you sure you want to change the base?
Initial setup for devcontainers for OSE project #556
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple questions for a quick review. I'd need to run this before I can approve it. Could you add some notes to the contributing file for how to run it?
"ghcr.io/duduribeiro/devcontainer-features/neovim:1": { | ||
"version": "nightly" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if there's a way to add LazyVim or Astro to this config?
.devcontainer/setup-foundry.sh
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We ought to prompt for a license key, too, or have some way to easily pull it from somewhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can open Foundry then using the provided launch.json (or just by running a command in the devcontainer) and it will ask you for serial number. I don't know how to provide it differently, but I will take a look
This PR adds a simple devcontainer setup that simplifies setting up a development environment.
To use this, you need docker and an editor that supports running devcontainers (or running them locally).