Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added required attribute to textArea. #501

Merged
merged 1 commit into from
Oct 3, 2018
Merged

Added required attribute to textArea. #501

merged 1 commit into from
Oct 3, 2018

Conversation

Decipher
Copy link
Contributor

@Decipher Decipher commented Oct 2, 2018 •
edited by lionel-bijaoui
Loading

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Bug? / Feature request.
  • What is the current behavior? (You can also link to an open issue here)
    If you use the required attribute for a textArea you'll get a required label but no HTML 5 validation, e.g., the form will submit even though it looks to be required.
  • What is the new behavior (if this is a feature change)?
    The HTML5 required attribute will be applied to the text area.
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No?
  • Other information:
    Unsure of the exact process for developing against this project, so can't confirm this PR is done as required.

@coveralls
Copy link

coveralls commented Oct 2, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 89.916% when pulling 9009096 on Realityloop:master into 4656dda on vue-generators:master.

lionel-bijaoui
lionel-bijaoui requested changes Oct 2, 2018
View reviewed changes
Copy link
Member

@lionel-bijaoui lionel-bijaoui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Decipher and thank you for your PR.
Can you please remove dist files and package-lock from it ?
They will be generated in the next release.

@zoul0813 zoul0813 self-requested a review October 2, 2018 13:41
@zoul0813
Copy link
Member

zoul0813 commented Oct 2, 2018

once the dist files are removed, I'll approve this PR

@Decipher
Copy link
Contributor Author

Decipher commented Oct 3, 2018

I'll make that change shortly.

Out of curiosity, is there an easy way for me to use my fork with the dist files until a release has this change? That's the main reason I committed those files, as I have a client who requires that change in a production site.

@zoul0813
Copy link
Member

zoul0813 commented Oct 3, 2018

My production project is based on my fork, just tell package.json to point to your github fork as the repo for it - can provide a sample tomorrow if you need one. Readup on package.json and Git repos option.

@Decipher
Copy link
Contributor Author

Decipher commented Oct 3, 2018

@zoul0813 I meant, because I have to remove the dist files for the PR, but I need the built dist files for me client, what the recommended approach there was.

It's all sorted now, I simply made a branch with the dist files and removed the dist files from this branch, and then pointed the package.json at the branch with the dist files. It just feels a little weird to me, but seems to get the job done.

@lionel-bijaoui
Copy link
Member

@Decipher Thank you for your work !

@zoul0813 zoul0813 merged commit d1dcf20 into vue-generators:master Oct 3, 2018
@zoul0813 zoul0813 mentioned this pull request Oct 3, 2018
Merged
This was referenced Oct 16, 2018
Merged
Merged
lionel-bijaoui pushed a commit to lionel-bijaoui/vue-form-generator that referenced this pull request Oct 18, 2018
vue-generators#501
7adcc11
@lionel-bijaoui lionel-bijaoui mentioned this pull request Oct 18, 2018
Merged
3 tasks
lionel-bijaoui added a commit that referenced this pull request Oct 18, 2018
@lionel-bijaoui
Merge pull request #530 from lionel-bijaoui/lb_implement_501_509_521_522
55b5d9f 
Implement #501 #509 #521 #522
zoul0813 added a commit to zoul0813/vue-form-generator that referenced this pull request Dec 22, 2018
@zoul0813
Merge branch 'v3' of github.com:vue-generators/vue-form-generator int…
9e1d797 
…o v3

* 'v3' of github.com:vue-generators/vue-form-generator:
  Bump version to 3.0.0-beta.7 - Update dependencies - Export dist files
  Single export - No more core vs full since both are the same right now - Optionnal fields will be removed from it in future update
  Clean useless folders
  Update submodule dev
  Custom legend block for group - Possibility to use scoped-slot to customise fully how legend is build - Expose `group` and `groupLegend` in slot prop
  vue-generators#509
  vue-generators#522
  vue-generators#521
  vue-generators#501
  Fix deep property path not working
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lionel-bijaoui lionel-bijaoui lionel-bijaoui approved these changes

@zoul0813 zoul0813 Awaiting requested review from zoul0813

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Decipher @coveralls @zoul0813 @lionel-bijaoui