Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

listen for model-updated from fields, and fix `debounceFormatFuncti… #555

Merged

Conversation

zoul0813
Copy link
Member

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Fixes the bug reported in #554

  • What is the current behavior? (You can also link to an open issue here)
    'model-updated' is not called when using 'fields', but works when using 'groups'
  • What is the new behavior (if this is a feature change)?
    'model-updated' is emitted for both 'fields' and 'groups'
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

No

  • Other information:

  • Refer to @model-updated not working in newer versions #554 for details

  • Also changed 'debouncedFormatFunction' to be 'debouncedFormatFunc' to follow naming convention of 'debouncedValidateFunc' and 'formInput' already used 'debouncedFormatFunc' (likely with warnings/errors since it was declared incorrectly).

…on` property to match fieldInput's `debounceFormatFunc` instead.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.916% when pulling 7ad1fca on zoul0813:feature/554-model-updated-fix into a484031 on vue-generators:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.916% when pulling 7ad1fca on zoul0813:feature/554-model-updated-fix into a484031 on vue-generators:master.

@zoul0813 zoul0813 merged commit 1ce7045 into vue-generators:master Dec 14, 2018
@zoul0813 zoul0813 deleted the feature/554-model-updated-fix branch December 14, 2018 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants