Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon component is not respecting static classes when there is dynamic classes #371

Closed
1 task done
nandin-borjigin opened this issue Jan 4, 2019 · 2 comments
Closed
1 task done
Labels

Comments

@nandin-borjigin
Copy link

  • I have searched the issues of this repository and believe that this is not a duplicate.

Version

1.2.3

Environment

macOS 10.14.1 (18B75), Chrome Version 71.0.3578.98 (Official Build) (64-bit), Vue 2.5.17

Reproduction link

Edit on CodeSandbox

Steps to reproduce

Insert <a-icon/> anywhere with both static classes and dynamic classes, like:
<a-icon type="phone" class="a" :class="['b']"/>

Then the rendered result won't include class 'a'.

What is expected?

static classes should be respected

What is actually happening?

<a-icon> repects dynamic classes over static classes

@tangjinzhou
Copy link
Member

please update to 1.2.5

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants