Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: patch postcss 7 and bundle it in the published npm package #111

Merged
merged 3 commits into from
Jun 9, 2021

Conversation

haoqunjiang
Copy link
Member

Backports
postcss/postcss@8682b1e
postcss/postcss@b6f3e4d

Fixes https://www.npmjs.com/advisories/1693

As postcss 7 isn't gonna release a new patch unless with commercial support, we have to patch it ourselves with patch-package.

It is to avoid introducing breaking changes to the downstream vue-loader v15.x.

The patched source code will be shipped with the @vue/component-compiler-utils npm package.
So users can get rid of the vulnerability warnings.

For any potential vulnerabilities in the future, we'll still receive them from GitHub's dependabot. So this change won't affect the overall security of this package.

Fixes #110
Fixes vuejs/vue-cli#6467

Closes #109

@haoqunjiang haoqunjiang requested review from znck and yyx990803 June 1, 2021 11:40
yanfali pushed a commit to qmk/qmk_configurator that referenced this pull request Jun 2, 2021
@haoqunjiang haoqunjiang merged commit cab504f into master Jun 9, 2021
@haoqunjiang haoqunjiang deleted the fix-bundle-postcss-7 branch June 9, 2021 01:42
haoqunjiang added a commit that referenced this pull request Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

https://www.npmjs.com/advisories/1693 npm audit fails due to postcss
1 participant