Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Function PropType #208

Closed
rndmerle opened this issue Dec 20, 2019 · 1 comment · Fixed by #212
Closed

Function PropType #208

rndmerle opened this issue Dec 20, 2019 · 1 comment · Fixed by #212
Labels
good first issue Good for newcomers

Comments

@rndmerle
Copy link

Hello.

This Vue issue and this commit refer to allowing:

props: {
  fn: Function as PropType<() => any>
}

Would it be possible to replicate this change on componentProps.d.ts's PropConstructor type please?

Thanks for your work :)
@posva posva added the good first issue Good for newcomers label Dec 21, 2019
genie-youn added a commit to genie-youn/composition-api that referenced this issue Dec 25, 2019
@genie-youn
fix(types): Function PropType (vuejs#208)
0eb44f9
@genie-youn genie-youn mentioned this issue Dec 25, 2019
Merged
@genie-youn
Copy link
Contributor

Hi @posva 😄
I made a PR and be so happy if you could check it.

Thanks you.

@rijkvanzanten rijkvanzanten mentioned this issue Jan 20, 2020
Closed
haoqunjiang added a commit that referenced this issue Feb 25, 2020
@genie-youn @haoqunjiang
fix(types): Function PropType (#208) (#212)
a5ace7f 
* fix(types): Function PropType (#208)

* revert style

* revert style

* revert style

* rebase upstream branch

* Update test/types/defineComponent.spec.ts

* Update test/types/defineComponent.spec.ts

* Update defineComponent.spec.ts

Co-authored-by: Haoqun Jiang <[email protected]>
pikax pushed a commit to pikax/vue-function-api that referenced this issue Apr 19, 2020
@genie-youn @haoqunjiang @pikax
fix(types): Function PropType (vuejs#208) (vuejs#212)
02d798d 
* fix(types): Function PropType (vuejs#208)

* revert style

* revert style

* revert style

* rebase upstream branch

* Update test/types/defineComponent.spec.ts

* Update test/types/defineComponent.spec.ts

* Update defineComponent.spec.ts

Co-authored-by: Haoqun Jiang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(types): Function PropType (#208) genie-youn/composition-api
3 participants
@rndmerle @posva @genie-youn