feat: prop and attr modifiers for v-bind #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ygj6
force-pushed
the
feat/v-bind-modifiers
branch
from
77c92b7 to
9806d8a
Compare
# Conflicts: # packages/compiler-vapor/__tests__/__snapshots__/compile.spec.ts.snap # packages/compiler-vapor/__tests__/transforms/__snapshots__/vBind.spec.ts.snap # packages/compiler-vapor/__tests__/transforms/vBind.spec.ts
Size ReportBundles
Usages
|
# Conflicts: # packages/compiler-vapor/__tests__/__snapshots__/compile.spec.ts.snap # packages/compiler-vapor/__tests__/transforms/__snapshots__/vBind.spec.ts.snap # packages/compiler-vapor/__tests__/transforms/vBind.spec.ts
ygj6
force-pushed
the
feat/v-bind-modifiers
branch
from
f0a872b to
0425692
Compare
|
Hi @sxzz is there anything I can do to help this PR get merged. Can you review it when you have time? |
sxzz
reviewed
Jan 17, 2024
|
Let's merge this now and feel free to create another PR for optimizing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close: #76
I refactored some of the logic in
setDynamicPropand integrated it intogenSetPropto replacesetAttr. This change should align better with the core logic.