Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compiler-ssr): support dynamic components that resolve to element(fix: #1508) #1512

Closed
wants to merge 1 commit into from
Closed

feat(compiler-ssr): support dynamic components that resolve to element(fix: #1508) #1512

wants to merge 1 commit into from

Conversation

HcySunYang
Copy link
Member

For template:

<component
  :is="multiline ? 'textarea' : 'input'"
  a=b
/>

Before:

import { resolveDynamicComponent as _resolveDynamicComponent, mergeProps as _mergeProps } from "vue"
import { ssrRenderComponent as _ssrRenderComponent } from "@vue/server-renderer"

export function ssrRender(_ctx, _push, _parent, _attrs) {
  _push(_ssrRenderComponent(_resolveDynamicComponent(_ctx.multiline ? 'textarea' : 'input'), _mergeProps({ a: "b" }, _attrs), null, _parent))
}

Now:

import { resolveDynamicComponent as _resolveDynamicComponent, mergeProps as _mergeProps } from "vue"
import { ssrIsComponent as _ssrIsComponent, ssrRenderComponent as _ssrRenderComponent, ssrRenderVNode as _ssrRenderVNode } from "@vue/server-renderer"

export function ssrRender(_ctx, _push, _parent, _attrs) {
  let _temp0

  _temp0 = _resolveDynamicComponent(_ctx.multiline ? 'textarea' : 'input')
  if (_ssrIsComponent(_temp0)) {
    _push(_ssrRenderComponent(_temp0, _mergeProps({ a: "b" }, _attrs), null, _parent))
  } else {
    _ssrRenderVNode(_temp0, _mergeProps({ a: "b" }, _attrs), null, _push, _parent)
  }
}

I think this can work?

@HcySunYang
Copy link
Member Author

#1508

@dsonet
Copy link
Contributor

dsonet commented Jul 6, 2020

It's may not a good idea to expose this logic in generated ssrRender function. I think the better way is to handle this in library layer.

@yyx990803
Copy link
Member

Thanks for the PR, but it can be simpler by just using renderVNode directly: 41db49d

@yyx990803 yyx990803 closed this Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants