Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(playground): fix github button style #7722

Merged
merged 3 commits into from
Jul 9, 2023
Merged

fix(playground): fix github button style #7722

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
49bf4f2
fix(playground): fix github button style
BeADre Feb 16, 2023
78f657d
style: merge selector
BeADre Feb 16, 2023
d276c49
Update Header.vue
Justineo Feb 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 17 additions & 8 deletions packages/sfc-playground/src/Header.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,14 +149,14 @@ async function fetchVersions(): Promise<string[]> {
>
<Download />
</button>
<button title="View on GitHub" class="github">
<a
href="https://github.com/vuejs/core/tree/main/packages/sfc-playground"
target="_blank"
>
<GitHub />
</a>
</button>
<a
href="https://github.com/vuejs/core/tree/main/packages/sfc-playground"
target="_blank"
title="View on GitHub"
class="github"
>
<GitHub />
</a>
</div>
</nav>
</template>
Expand Down Expand Up @@ -299,6 +299,15 @@ h1 img {
color: var(--highlight);
}

.links .github {
color: var(--btn);
padding: 1px 6px;
}

.links .github:hover {
color: var(--highlight);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to merge this into L292:300:

.links > button,
.links > a {
  padding: 1px 6px;
  color: var(--btn);
}

.links > button:hover,
.links > a:hover {
  color: var(--highlight);
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done


.version:hover .active-version::after {
border-top-color: var(--btn);
}
Expand Down