Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(effect): verify cleanupEffect clears multiple dependencies #9503

Merged
merged 3 commits into from
Jun 6, 2024
Merged

test(effect): verify cleanupEffect clears multiple dependencies #9503

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
361c7ea
test(effect): verify cleanupEffect clears multiple dependencies
jh-leong Oct 30, 2023
9e43d4a
Merge branch 'main' into patch
jh-leong Nov 17, 2023
e0eec11
Merge branch 'main' into patch
yyx990803 Jun 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions packages/reactivity/__tests__/effect.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -830,6 +830,31 @@ describe('reactivity/effect', () => {
expect(dummy).toBe(3)
})

it('stop with multiple dependencies', () => {
let dummy1, dummy2
const obj1 = reactive({ prop: 1 })
const obj2 = reactive({ prop: 1 })
const runner = effect(() => {
dummy1 = obj1.prop
dummy2 = obj2.prop
})

obj1.prop = 2
expect(dummy1).toBe(2)

obj2.prop = 3
expect(dummy2).toBe(3)

stop(runner)

obj1.prop = 4
obj2.prop = 5

// Check that both dependencies have been cleared
expect(dummy1).toBe(2)
expect(dummy2).toBe(3)
})

it('events: onStop', () => {
const onStop = vi.fn()
const runner = effect(() => {}, {
Expand Down