fix: redundant re-render and loss of collapsed state for inspector tree/state component #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vue-devtools-docs canceled.
|
Azurewarth0920
force-pushed
the
fix/fix-forced-rerender-on-panels
branch
from
07643e9 to
2c1d0aa
Compare
Azurewarth0920
commented
Jan 1, 2024
webfansplz
changed the title
webfansplz
changed the title
|
LGTM, thanks. |
webfansplz
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #110
Fix redundant re-render on InspectorState panel
Before:
The +/- buttons keep flickering (unnecessary rerender) and the whole InspectorState panel tree keeps rerendering.
before.mov
After:
Only the count is updated.
after.mov
Keep collapsed state on component inspect panel
The collapsed state is always re-created after the component is updated and the current state is discarded.
Merge the current state into the re-calculated state.