-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vue does not perform 100% anymore at Web Components test #1708
Comments
This comment was marked as off-topic.
This comment was marked as off-topic.
Related: #1553 |
This comment was marked as off-topic.
This comment was marked as off-topic.
@skirtles-code I think I'd be in favor of reflecting this current state of affairs in the docs, given that the workaround that I proposed to them is still in concideration but seems to be stuck. We could reflect the actual current score in the docs and add a small section explaining the workarounds:
app.directive('event', {
beforeMount((el, { arg, value }) => {
el.addEventListener(arg, value)
}),
unmounted((el, { arg, value }) => {
el.removeEventListener(arg, value)
})
} <my-custom-el v-event:PascalCase="handleEvent"> That would of course also only work in build-time compilation as string compilation at runtime would lowercase the arg before the compiler processes it. Thoughts? |
…mes on custom elements close vuejs/docs#1708 close vuejs/docs#1890
On this page: https://vuejs.org/guide/extras/web-components.html#using-custom-elements-in-vue it is said that vue performs 100% at Custom Elements Everywhere test.
It seems that the test has changed now. 3 tests failed. Until vue comes back to 100% this line should probably be updated or removed.
The text was updated successfully, but these errors were encountered: