Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Lifecycle Hooks" page feels out of place in the current order #3094

Closed
midskyey opened this issue Nov 5, 2024 · 0 comments · Fixed by #3125
Closed

"Lifecycle Hooks" page feels out of place in the current order #3094

midskyey opened this issue Nov 5, 2024 · 0 comments · Fixed by #3125

Comments

@midskyey
Copy link
Contributor

midskyey commented Nov 5, 2024

The page Lifecycle Hooks is currently placed here

screenshot of sidebar with "Lifecycle Hooks" selected

and it is pretty much about component lifecycle hooks; however, at this point in the guide, "components" and their "instances" have not been properly introduced yet, and the value of covering their lifecycle hooks at this point is a bit doubtful.

It feels like placing Lifecycle Hooks after Components Basics (either immediately after in Essentials, or later in Components In-Depth) would fit narratively better.
kvanvigs added a commit to kvanvigs/docs that referenced this issue Dec 7, 2024
@kvanvigs
Fixed issue vuejs#3094
ae3cbb7 
It was stated that Lifecycle hooks should be at the end of the essentials tab because it fits the narrative better. vuejs#3094
@kvanvigs kvanvigs mentioned this issue Dec 7, 2024
Merged
@NataliaTepluhina NataliaTepluhina linked a pull request Dec 9, 2024 that will close this issue
docs: changed lifecycle hooks to be after components basics in sidebar #3125
Merged
NataliaTepluhina pushed a commit that referenced this issue Dec 9, 2024
@kvanvigs
docs: changed lifecycle hooks to be after components basics in sidebar (
7d15b57 
#3125)

* Add files via upload

tesst

* Delete test.txt

* Fixed issue #3094

It was stated that Lifecycle hooks should be at the end of the essentials tab because it fits the narrative better. #3094
szymonlicau pushed a commit to monterail/vue3-docs-pl that referenced this issue Dec 9, 2024
@kvanvigs @szymonlicau
docs: changed lifecycle hooks to be after components basics in sidebar (
a80873d 
vuejs#3125)

* Add files via upload

tesst

* Delete test.txt

* Fixed issue vuejs#3094

It was stated that Lifecycle hooks should be at the end of the essentials tab because it fits the narrative better. vuejs#3094
Baroshem added a commit to monterail/vue3-docs-pl that referenced this issue Jan 30, 2025
@Baroshem
Merge pull request #98 from monterail/7d15b579
358a555 
docs: changed lifecycle hooks to be after components basics in sidebar

* Add files via upload

tesst

* Delete test.txt

* Fixed issue vuejs#3094

It was stated that Lifecycle hooks should be at the end of the essentials tab because it fits the narrative better. vuejs#3094 (#97)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: changed lifecycle hooks to be after components basics in sidebar kvanvigs/docs
1 participant
@midskyey