Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add eslint alongside prettier #1403

Merged
merged 2 commits into from
Apr 8, 2022
Merged

Conversation

freakzlike
Copy link
Collaborator

This will add eslint alongside prettier. Code formatting should still work as before.

At the moment I have disabled the following rules to avoid a lot of code changes for now. I can do it at some time.

'@typescript-eslint/no-explicit-any': 'off',
'@typescript-eslint/no-non-null-assertion': 'off',
'@typescript-eslint/no-unused-vars': 'off',
'@typescript-eslint/ban-types': 'off',
'@typescript-eslint/no-empty-function': 'off',
'@typescript-eslint/ban-ts-comment': 'off',
'prefer-const': 'off',
'no-prototype-builtins': 'off'

The rule no-restricted-imports ensures that no import from src has been made and will prevent issues like #1401

@netlify
Copy link

netlify bot commented Apr 6, 2022

Deploy Preview for vue-test-utils-docs ready!

Name Link
🔨 Latest commit 68a1098
🔍 Latest deploy log https://app.netlify.com/sites/vue-test-utils-docs/deploys/624eec109ca6ac00090bd510
😎 Deploy Preview https://deploy-preview-1403--vue-test-utils-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@cexbrayat cexbrayat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks great, thanks @freakzlike

@cexbrayat
Copy link
Member

Arf, I merged other PRs first, and this one now has a conflict. @freakzlike would you mind rebasing it please?

# Conflicts:
#	yarn.lock
@lmiller1990 lmiller1990 merged commit 8c21571 into vuejs:main Apr 8, 2022
@freakzlike freakzlike deleted the chore/eslint branch April 8, 2022 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants