Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add line break in JSDoc #2214

Merged
merged 2 commits into from
Sep 3, 2020
Merged

Conversation

sapphi-red
Copy link
Contributor

In .ts file, VSCode shows JSDoc in multiple lines.
image

So I changed it to make Vetur acts the same.

Before

image
image

After

image
image

refs b88a39d e21fe22

This PR includes a user-facing change but it does not affect most users, since this change is based on a unreleased change.
Should I update CHANGELOG.md?

@sapphi-red sapphi-red force-pushed the add-line-break-in-jsdoc branch from 4f3f422 to bfb129e Compare August 31, 2020 00:23
@sapphi-red sapphi-red changed the title Added line break in JSDoc Add line break in JSDoc Aug 31, 2020
@octref
Copy link
Member

octref commented Sep 3, 2020

Should I update CHANGELOG.md?

Go ahead & thanks for contributing 👍

@octref
Copy link
Member

octref commented Sep 3, 2020

I'll do a release soon. If you haven't got a chance to update by end of today, I'll add your contribution log to changelog and publish. Thank you.

@sapphi-red
Copy link
Contributor Author

OK. I'll update it around 20:00 JST (11:00 UTC)!

@sapphi-red sapphi-red force-pushed the add-line-break-in-jsdoc branch from 18334af to 7972af6 Compare September 3, 2020 10:16
@sapphi-red
Copy link
Contributor Author

@octref I have updated the changelog and solved conflict. 🚀

Copy link
Member

@octref octref left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@octref octref merged commit ba2be01 into vuejs:master Sep 3, 2020
@sapphi-red sapphi-red deleted the add-line-break-in-jsdoc branch September 3, 2020 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants