-
-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prefer file local prettier #876
Conversation
Btw, thanks for the awesome extension and really appreciate the work you did in #873! hopefully this takes us to 1/15 😄 |
@octref any comments on this PR? thanks in advance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Rebase on master
- Add copyright notice, since this code is largely from vscode-prettier
requireLocalPkg
forprettier-eslint
too
Sorry for the late response. Mostly look good. Once you make the requested changes I'll pull it in. |
99e2b84
to
47c6ea0
Compare
Hi @octref, changes made. re: copyright, I added an entry into ThirdPartyNotices with the LICENSE from prettier-vscode. is that what you meant? If not, let me know if there's something else I can do. |
@maeldur Thanks for adding it to the ThirdPartyNotice. In the /**
* Adapted from https://github.com/prettier/prettier-vscode/blob/1843acb5defac7898862a1df61cb67c7a8355d69/src/requirePkg.ts
*/ |
@octref thanks for the review - added. i went 9 digits into the sha for the blob but if you prefer the long one i'll use the whole thing. |
Thanks again. I just made a release. I'll try to bring in prettyhtml and make a new release again. |
I brought in the file from prettier-vscode to have vetur behave the same way as that extension
I've tested this change with no prettier, an older version of prettier, and a newer one and it seems to work ok.. is there more formal testing i should do?