-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change createMarkdownRenderer base to default to ''
#555
Comments
It would also be nice if the parameter could be renamed to |
Throughout the codebase, base is referred by
Whatever done in that PR concerns an internal API, and not meant to be used directly. That said, we can probably change these vitepress/src/node/markdownToVue.ts Line 30 in 06ad0d8
vitepress/src/node/markdown/markdown.ts Line 54 in 06ad0d8
to |
https://github.com/vuejs/vitepress/blob/main/CHANGELOG.md#0203-2021-12-07 I thought this meant it is public API. |
Ah, didn't looked that. If it is exposed, then yeah it can be used. We probably need to document this too. Fine, I'll just create a PR to add a default base value for now. |
804954c#diff-332834eb76757b8e31926e411cef34f7207564d0bf5fd00a185b41d97b3403bfR53
This change is not backwards compatible, it would be nice if the value could be set by default.
Originally posted by @ST-DDT in #502 (comment)
The text was updated successfully, but these errors were encountered: