Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(typescript): add useDefineForClassFields option in tsconfig template #6235

Merged
merged 1 commit into from
Jan 25, 2021

Conversation

ktsn
Copy link
Member

@ktsn ktsn commented Jan 24, 2021

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:

Added this option in the template because vue-class-component introduced a new API that encourages users to set useDefineForClassFields: true.

It would also make sense for non-class component users to enable this option as it follows the standard class field behavior AFAIK.

Ref: https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-7.html#the-usedefineforclassfields-flag-and-the-declare-property-modifier

@haoqunjiang haoqunjiang merged commit 634bf59 into vuejs:dev Jan 25, 2021
@ktsn ktsn deleted the update-tsconfig-template branch January 25, 2021 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants