New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Improve axios mock on async testing #940

Merged

eddyerburgh merged 1 commit into vuejs:dev from udebella:docs/improve-axios-mock

Aug 22, 2018

Contributor

udebella commented Aug 22, 2018

Hello, first time I open a pull request on an open source project, I may have missed something.

I use the library for like a month now and found a little improvement in the docs by using Promise.resolve directly.

I made the same change in other languages too.
I did not bother creating an issue for a tiny change like that, but I can create one if you like.


          docs: Improve axios mock on async testing

133bf12

eddyerburgh approved these changes

View reviewed changes

Member

eddyerburgh left a comment

Thanks, this is definitely an improvement. I also write Promises like this in tests 👍

eddyerburgh merged commit 22b909e into vuejs:dev

udebella deleted the docs/improve-axios-mock branch

August 22, 2018 19:55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet