-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: directive lifecycle hooks in v-for
, v-if
and component
#123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vapor-repl ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for vapor-template-explorer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Size ReportBundles
Usages
|
8605d92
to
8a2a2ac
Compare
v-for
v-for
/v-if
I created a Demo in Playground to test this feature |
965f31b
to
cfca161
Compare
76fbceb
to
26ad63b
Compare
Optimized the performance. |
1 task
38c9d9f
to
f75e834
Compare
2fa93ac
to
63a2cd8
Compare
63a2cd8
to
874dd8a
Compare
874dd8a
to
f584ca6
Compare
d387242
to
0a707c4
Compare
0a707c4
to
6de3a81
Compare
Great job! Thank you for your contribution! |
v-for
/v-if
v-for
, v-if
and component
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected Behavior of Directive Lifecycle within
v-for
Create Item
new item:
created
->beforeMount
->mounted
other everyone:
beforeUpdate
->updated
all events:
beforeUpdate
->created
->beforeMount
->updated
->mounted
Remove Item
removed item:
beforeUnmount
->unmounted
other everyone:
beforeUpdate
->updated
all events:
beforeUpdate
->beforeUnmount
->updated
->unmounted
Move Item
everyone:
beforeUpdate
->updated
I've created new
BlockEffectScope
andcreateChildFragmentDirectives
APIs that I hope will help make it easier to implement Lifecycle Hooks in Vapor. such as the lifecycle in slots or in components