refactor($compile): Disable warn if v-model is used with ternary text-like types for input. #6227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable warn if v-model is used with ternary text-like types for input
nickmessing
force-pushed
the
fix/unnecesarry-warn-v-model-ternary
branch
from
5bfb797 to
a62d82a
Compare
nickmessing
commented
Jul 26, 2017
| @@ -4,6 +4,7 @@ import config from 'core/config' | |||
| import { addHandler, addProp, getBindingAttr } from 'compiler/helpers' | |||
| import { genComponentModel, genAssignmentCode } from 'compiler/directives/model' | |||
|
|
|||
| const ternaryTextInputRE = /^[^?]{1,}\?\s*('|"|`)(?:text|number|password|search|email|tel|url)\1\s*:\s*('|"|`)(?:text|number|password|search|email|tel|url)\2\s*$/ | |||
There was a problem hiding this comment.
Does a regexp like this introduce too much complexity that's not worth it?
There was a problem hiding this comment.
Shouldn't use makeMap be enough? Don't we want to check if dynamic type is one of those?
There was a problem hiding this comment.
oh, you actually did that an #6344
we need the opposite 😆
There was a problem hiding this comment.
I meant for the makeMap function 😆
There was a problem hiding this comment.
Oh, yeah, we could use
/^[^?]{1,}\?\s*('|"|`)([a-z]*)\1\s*:\s*('|"|`)([a-z]*)\3\s*$/
and just checks [2] and [4] with makeMap. I'll add this changes to #6344 instead because isTextInputType is moved over there.
13 tasks
|
Move to #6344 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch for v2.x (or to a previous version branch), not themasterbranchfix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
#6158