#1647 Remove PhantomJS from E2E test, and use Chrom Headless Webdriver #1648
Conversation
kiaking
changed the title
| @@ -20,7 +20,7 @@ module.exports = { | |||
| .assert.containsText('.cart', 'H&M T-Shirt White - $10.99 x 1') | |||
| .assert.containsText('.cart', 'Total: $1,011.01') | |||
| .click('.cart button') | |||
| .waitFor(120) | |||
| .waitFor(200) | |||
There was a problem hiding this comment.
I needed to change this because test was failing... Not sure why.
| @@ -105,7 +105,7 @@ module.exports = { | |||
| .dblClick('.todo:nth-child(1) label') | |||
| .assert.count('.todo.editing', 1) | |||
| .assert.focused('.todo:nth-child(1) .edit') | |||
| .clearValue('.todo:nth-child(1) .edit') | |||
| deleteValue('.todo:nth-child(1) .edit', 'test2') | |||
There was a problem hiding this comment.
clearValue was not working. Not sure why but after clearValue, 2 todos was removed before setValue. So I'm guessing clearValue is emitting blur event or something...
So, I went ahead and created deleteValue function which will input "backspace" and deletes value. If this is the only workaround we have at the moment, I would like to extract that into a custom command so that we can do browser.deleteValue. Ref: Custom Command Doc
|
Updated Nightwatch to the latest version. Though it didn't fix |
|
Hmmm... no idea why test is failing on circleci... |
|
@kiaking |
|
@kazupon Ohhhh what the hell is that |
|
OK I've optimized the Nightwatch config and circleci is padding, though I think it had nothing to do with it. Perhaps timing issue... |
|
@ktsn Oh hi! What do you think about this? |
|
Hey @kiaking, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚 |
…driver (vuejs#1648) * Remove PhantonJS from E2E test, and use Chrom Headless Webdriver * Update Nightwatch * Optimise Nighteatch config
Issue #1647
This PR removes PhantomJS from E2E test because it is not supported anymore. Instead, Chrome Headless Driver is used.